Resize hover cards only based on <dl>, not .hover-card-title #1103
+135
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Dec 13, 2024
src/components/hover-card.vue
Outdated
| // Returning 0 means that the default width should be used. | ||
| const computeBodyWidth = () => { | ||
| if (props.truncateDt) return 0; | ||
| const dd = [...el.value.querySelectorAll('dd')]; |
There was a problem hiding this comment.
I guess I don't need to get all the <dd> elements anymore, just the first.
sadiqkhoja
reviewed
Dec 14, 2024
src/components/hover-card.vue
Outdated
Comment on lines
82
to
84
| const otherChildren = [...el.value.querySelectorAll(':scope > *:not(.hover-card-body)')]; | ||
| for (const child of otherChildren) child.style.display = 'none'; | ||
| el.value.style.width = 'auto'; |
There was a problem hiding this comment.
if we move ref="el" from the root to .hover-card-body then we can avoid this, right?
Never mind, I see why this is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with how hover cards are currently sized. See the discussion that starts at #1097 (review).
What has been done to verify that this works as intended?
I tried it out locally in Chrome and Firefox. I also wrote tests.
These are my go-to scenarios when trying things out locally:
<dd>reaches the width of the<dt>.<dd>should be less wide than the<dt>.Why is this the best possible solution? Were any other approaches considered?
The key idea here is to hide the heading and footer of the hover card when determining the ideal width of the body.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I'll ask the QA team to take a look.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes